Remove faker NHS number monkeypatch

A few months ago, we monkey patched our codebase (#1338) to work around the faker gem generating real NHS numbers. This has now been fixed upstream in faker (faker-ruby/faker#2947) and released in https://github.com/faker-ruby/faker/releases/tag/v3.4.2.
nhsuk · Sep 18, 2024 · 3dc8811 · 3dc8811
1 parent 1c15a92
commit 3dc8811
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 23 deletions.
diff --git a/spec/factories/patients.rb b/spec/factories/patients.rb
@@ -51,7 +51,7 @@
 
     recorded_at { Time.zone.now }
 
-    nhs_number { Faker::NationalHealthService.test_number.gsub(/\s+/, "") }
+    nhs_number { Faker::NationalHealthService.british_number.gsub(/\s+/, "") }
 
     first_name { Faker::Name.first_name }
     last_name { Faker::Name.last_name }

diff --git a/spec/support/faker/national_health_service.rb b/spec/support/faker/national_health_service.rb