fix(error_handling): introduce IntoError trait to reduce coherence issues #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous reliance on the From and Into traits lead to coherence violations for users who may want to implement anything more than a simple mapping to a String or StatusCode. BREAKING CHANGE: The error_handling example and the IntoError trait documentation have a number of different examples of trait implementation, for both foreign types and crate local types. Hopefully they should cover most of the usage which may be broken from this change.
…fn pointers This should be strictly more generic and should hopefully not be considered a breaking change.
|
This is great! The examples are clear and I do not see any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase-ish of #304
I don't think this will actually be that breaking, but since it is breaking I'd like to get it in with the next release.
The related PR came up during nickel-org/nickel-postgres#17 (comment) as well which was getting coherence problems which this should hopefully fix.
cc @flosse @hjr3