added start/stop feature #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GabriFedi thanks for the PR, looks good, but it's hard for me to look at the differences as your formatter has added 4 spaces and I'm using 2. Can you revert those formatter changes and I can continue with the review? Thanks! |
|
@nicodelpiano try now |
|
Hi @GabriFedi, the code looks better! Just tested it and the Also left minor comments regarding formatter 🙏 😄 Thank you! |
nicodelpiano
reviewed
Oct 8, 2019
| @@ -26,17 +69,19 @@ function drawStep(ctx, step) { | |||
| clearCanvas(ctx) | |||
| let xPosition = 0 | |||
| let yPosition = CANVAS_HEIGHT | |||
|
|
|||
nicodelpiano
reviewed
Oct 8, 2019
| const values = step.array | ||
| const [i, j] = step.swapPositions || [-1, -1] | ||
|
|
||
|
|
||
| //console.log('valuse', values.entries()); |
nicodelpiano
reviewed
Oct 8, 2019
| ? PIVOT_RECT_COLOR | ||
| : index === j | ||
| ? SWAPPED_RECT_COLOR | ||
| : DEFAULT_RECT_COLOR |
There was a problem hiding this comment.
can you rever the format that was before? see the diff on the left
nicodelpiano
reviewed
Oct 8, 2019
| const canvas = document.getElementById('myCanvas') | ||
| canvas.width = CANVAS_WIDTH | ||
| canvas.height = CANVAS_HEIGHT | ||
| const ctx = canvas.getContext('2d') | ||
|
|
||
nicodelpiano
reviewed
Oct 8, 2019
| @@ -115,7 +172,7 @@ document.addEventListener('DOMContentLoaded', function(event) { | |||
| } | |||
| }) | |||
| }) | |||
|
|
|||
nicodelpiano
reviewed
Oct 8, 2019
| @@ -60,7 +60,7 @@ function quickSortHelper(array, startIndex, endIndex, steps = []) { | |||
| } | |||
| swapAndTrackSteps(array, pivotIndex, rightIndex, steps) | |||
| const isLeftSubarraySmaller = | |||
| rightIndex - 1 - startIndex < endIndex - leftIndex - 1 | |||
| rightIndex - 1 - startIndex < endIndex - leftIndex - 1 | |||
There was a problem hiding this comment.
See the diff on the left, there's two spaces identation here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.