Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat notes with velocity of zero as off #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Treat notes with velocity of zero as off #26

wants to merge 1 commit into from

Commits on Aug 9, 2024

  1. Treat notes with velocity of zero as off 

    See this issue for more details
nicorobo#20

TL;DR: some midi instruments send a "note on" message with velocity zero instead of "note off" messages. Prior to this change, the `useMidiNotes` hook would never remove notes from the list when using these instruments. Now those instruments work like other ones.
    @pcardune
    pcardune committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ed22484 View commit details
    Browse the repository at this point in the history