Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor sql_json endpoint #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor sql_json endpoint #31

wants to merge 3 commits into from

Conversation

ofekisr
Copy link
Collaborator

@ofekisr ofekisr commented Aug 18, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

return mocked_query


@mark.ofek

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

ofekisr pushed a commit that referenced this pull request Dec 5, 2021
* feat: Add number-format package
ofekisr pushed a commit that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants