Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/sql json view14 #41

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Refactor/sql json view14 #41

wants to merge 15 commits into from

Conversation

ofekisr
Copy link
Collaborator

@ofekisr ofekisr commented Sep 20, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

Codecov Report

Merging #41 (aaedd14) into master (62637f2) will increase coverage by 0.00%.
The diff coverage is 73.62%.

❗ Current head aaedd14 differs from pull request most recent head bd2e42c. Consider uploading reports for the commit bd2e42c to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master      #41    +/-   ##
========================================
  Coverage   76.87%   76.88%            
========================================
  Files        1004     1005     +1     
  Lines       53989    54046    +57     
  Branches     7335     7463   +128     
========================================
+ Hits        41505    41551    +46     
- Misses      12245    12255    +10     
- Partials      239      240     +1     
Flag Coverage Δ
javascript 71.30% <81.01%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Menu/Menu.tsx 69.79% <ø> (ø)
...rontend/src/components/Select/DeprecatedSelect.tsx 82.35% <0.00%> (-3.37%) ⬇️
...et-frontend/src/dashboard/components/Dashboard.jsx 78.84% <ø> (ø)
...src/dashboard/components/gridComponents/Column.jsx 87.87% <ø> (ø)
...nd/src/dashboard/components/gridComponents/Row.jsx 86.66% <ø> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 72.22% <ø> (-1.39%) ⬇️
...nd/src/dashboard/components/nativeFilters/utils.ts 56.25% <ø> (ø)
...perset-frontend/src/dashboard/util/isValidChild.ts 85.71% <ø> (-0.96%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 14.28% <0.00%> (-0.72%) ⬇️
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62637f2...bd2e42c. Read the comment docs.

ofekisr pushed a commit that referenced this pull request Dec 5, 2021
#41)

* [typescript] add build support for typescript

* [typescript] working lint and build

* [typescript] refactor SupersetClient to TS

* [typescript][connection] leverage RequestInit types when relevant

* [typescript][connection] callApi.js => callApi.ts

* [typescript][connection] remaining .js => .ts

* [typescript][connection] add and export src/types.ts, refactor things, convert test to .ts and fix

* [typescript] build:ts only in typescript-containing packages
ofekisr pushed a commit that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants