add custom messages #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dev-sendcustommsg RPC method allows the user to inject a custom message into the communication with the peer with the given node_id.
The custommsg plugin hook is the receiving counterpart to the dev-sendcustommsg RPC method and allows plugins to handle messages that are not handled internally.
sputn1ck
force-pushed
the
dev-sendcustommsg
branch
from
752261d
to
95d240a
Compare
| } | ||
|
|
||
| func (r *CustomMessageRequest) Name() string { | ||
| return "dev-sendcustommsg" |
There was a problem hiding this comment.
This need to be changed to sendcustommsg, but I think there is no reason to specify it ElementsProject/lightning#4650 :)
|
|
||
| go 1.16 | ||
|
|
||
| require github.com/stretchr/testify v1.7.0 |
There was a problem hiding this comment.
From CD/CD I found the following error
# github.com/stretchr/testify/assert
../../stretchr/testify/assert/assertions.go:1738:5: undefined: errors.Is
../../stretchr/testify/assert/assertions.go:1761:6: undefined: errors.Is
../../stretchr/testify/assert/assertions.go:1784:5: undefined: errors.As
../../stretchr/testify/assert/assertions.go:1801:7: undefined: errors.Unwrap
../../stretchr/testify/assert/assertions.go:1805:7: undefined: errors.Unwrap
? github.com/niftynei/glightning/examples/plugin/pl_btc [no test files]
? github.com/niftynei/glightning/examples/plugin/pl_dbwrites [no test files]
? github.com/niftynei/glightning/examples/plugin/pl_example [no test files]
? github.com/niftynei/glightning/examples/plugin/pl_featurebits [no test files]
? github.com/niftynei/glightning/examples/plugin/pl_htlcacc [no test files]
? github.com/niftynei/glightning/examples/plugin/pl_method [no test files]
? github.com/niftynei/glightning/examples/plugin/pl_openchan [no test files]
? github.com/niftynei/glightning/examples/plugin/pl_rpccmd [no test files]
? github.com/niftynei/glightning/examples/rpc [no test files]
? github.com/niftynei/glightning/gbitcoin [no test files]
FAIL github.com/niftynei/glightning/glightning [build failed]
FAIL github.com/niftynei/glightning/glightning/tests [build failed]
FAIL github.com/niftynei/glightning/jrpc2 [build failed]
Maybe we need to downgrade some packages or update the test?
vincenzopalazzo
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
LGTM 95d240a, only a few comments to be read with c-lightning 0.10.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the dev-sendcustommsg rpc and custommsg hook.
I also added a go.mod to the project which allows for easier dependancy management.