New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revised PR, adresses comments #2

Merged

nikizadehgfdl merged 1 commit into nikizadehgfdl:raphDussin_multifile_dataoverride from raphaeldussin:feature_data_override_multifile_updated

Nov 27, 2023

raphaeldussin commented Nov 27, 2023

Hi @nikizadehgfdl

these changes address the review comments, namely:

missing check for 2 column (:) character
replaced default filename "none" to empty "" allows to only specify 2 forcing files
added check for spatial dimensions consistency between consecutive files
improved error messages


          revised PR, adresses comments

3a55485

nikizadehgfdl merged commit 0063c64 into nikizadehgfdl:raphDussin_multifile_dataoverride

19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet