Remove Temporary Serialization Shim (actions#2549)

nikola-jokic · May 12, 2023 · 195f070 · 195f070
1 parent 7b629c8
commit 195f070
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/src/Sdk/RSWebApi/Contracts/AcquireJobRequest.cs b/src/Sdk/RSWebApi/Contracts/AcquireJobRequest.cs
@@ -7,10 +7,5 @@ public class AcquireJobRequest
     {
         [DataMember(Name = "jobMessageId", EmitDefaultValue = false)]
         public string JobMessageId { get; set; }
-
-        // This field will be removed in an upcoming Runner release.
-        // It's left here temporarily to facilitate the transition to the new field name, JobMessageId.
-        [DataMember(Name = "streamId", EmitDefaultValue = false)]
-        public string StreamId { get; set; }
     }
 }
diff --git a/src/Sdk/RSWebApi/RunServiceHttpClient.cs b/src/Sdk/RSWebApi/RunServiceHttpClient.cs
@@ -65,7 +65,6 @@ public async Task<AgentJobRequestMessage> GetJobMessageAsync(
             var payload = new AcquireJobRequest
             {
                 JobMessageId = messageId,
-                StreamId = messageId,
             };
 
             requestUri = new Uri(requestUri, "acquirejob");

diff --git a/src/Test/L0/Sdk/RSWebApi/AcquireJobRequestL0.cs b/src/Test/L0/Sdk/RSWebApi/AcquireJobRequestL0.cs
@@ -14,11 +14,9 @@ public sealed class AcquireJobRequestL0
     [Trait("Category", "Common")]
     public void VerifySerialization()
     {
-        var jobMessageId = "1526919030369-33";
         var request = new AcquireJobRequest
         {
-            JobMessageId = jobMessageId,
-            StreamId = jobMessageId
+            JobMessageId = "1526919030369-33"
         };
         var serializer = new DataContractJsonSerializer(typeof(AcquireJobRequest));
         using var stream = new MemoryStream();
@@ -27,7 +25,7 @@ public void VerifySerialization()
         stream.Position = 0;
         using var reader = new StreamReader(stream, Encoding.UTF8);
         string json = reader.ReadToEnd();
-        string expected = DoubleQuotify(string.Format("{{'jobMessageId':'{0}','streamId':'{0}'}}", request.JobMessageId));
+        string expected = DoubleQuotify(string.Format("{{'jobMessageId':'{0}'}}", request.JobMessageId));
         Assert.Equal(expected, json);
 
     }