Expands how cancellable requests work #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now they are `PendingRequests` and we keep track of the nimsuggest instance that depends on it (when possible) and also the time it got triggered. The pending requests are shown in the extension status panel, later we will be using the active pending requests to determine if a given instance of ns is hanging so we can restart it without user intervention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now they are
PendingRequestsand we keep track of the nimsuggest instance that depends on it (when possible) and also the time it got triggered. The pending requests are shown in the extension status panel, later we will be using the active pending requests to determine if a given instance of ns is hanging so we can restart it without user interventionNotice the
Pending Requests (15)in the img above are there because the ls is not removing complete requests, but in a regular usage they shouldnt be there (we may introduce a toggle for debugging purposes that dont remove them when complete) or we could just show all and remove complete ones after certain period has passed since it was completed