Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition of TL_API under GCC #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sebastinas
Copy link
Contributor

No description provided.

@njh
Copy link
Owner

njh commented Oct 23, 2019

@sebastinas thank you very much for this fix.

Do you know what I could have done to pick this up before releasing?
Travis is configured to build against GCC 5.4.0 on Ubuntu:
https://travis-ci.org/njh/twolame/jobs/598281337

And I have my own build job here:
https://ci.aelius.com/job/twolame/95/console

Which runs on Debian 10, with GCC 8.3.0

Is there an extra test that I need to do?

@sebastinas
Copy link
Contributor Author

What I did to find this issue is to check whether the .so only exports the functions defined in the public header (you can do that with nm -D and checking for the symbols marked with T). First, I noticed that too many symbols are exported. Then I've built with -fvisibility=hidden and ended up with no symbols. This uncovered the issue in the definition of TL_API. With that fixed, I noticed that one function was still missing.

@lazka
Copy link

lazka commented Nov 1, 2019

We also needed this patch for the Windows build: msys2/MINGW-packages#5919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants