Turn off additional deprecation warnings for GCC. #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In follow up from the conversation in nlohmann#1269, this adds the `-Wno-deprecate-declarations` flag to unit tests to allow them to test deprecated APIs without all the noisy compiler warnings. This also refactors the setting of build properties for test targets to use `target_<...>` commands instead of `set_target_properties()`.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In follow up from the conversation in #1269, this adds the
-Wno-deprecate-definitionsflag to unit tests to allow them to test deprecated APIs without all the noisy compiler warnings. This also refactors the setting of build properties for test targets to usetarget_<...>commands instead ofset_target_properties()