Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated year in README.md #1425

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Updated year in README.md #1425

merged 1 commit into from
Jan 12, 2019

Conversation

jef
Copy link
Contributor

@jef jef commented Jan 11, 2019

Updates the README from 2018 to 2019

Happy New Year 🎉

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@coveralls
Copy link

coveralls commented Jan 11, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 7f73915 on hijxf:patch-1 into df460c9 on nlohmann:develop.

@nickaein
Copy link
Contributor

There is another 2018 reference in very last lines of README.md in copyright note. Is there any reason to update/not update it?

There is also other references to 2018 throughout the code that should be considered.

@nlohmann
Copy link
Owner

No need to update the copyright years. I will do this with the next release.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jef
Copy link
Contributor Author

jef commented Jan 11, 2019

Awesome. Thanks!

@jef jef closed this Jan 11, 2019
@jef jef reopened this Jan 11, 2019
@jef
Copy link
Contributor Author

jef commented Jan 11, 2019

Accidentally closed.

Thanks,
Jef

@nlohmann nlohmann merged commit b39f34e into nlohmann:develop Jan 12, 2019
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants