Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix int64 min issue #1722

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Fix int64 min issue #1722

merged 3 commits into from
Sep 10, 2019

Commits on Sep 3, 2019

  1. Fix outputting extreme integer values in edge cases 

    For some gcc version (Ubuntu 5.5.0-12ubuntu1~16.04) the existing code
crashes when the minimum value of int64_t is outputted.

Resurrect the code from before 546e2cb (:rotating_light: fixed some warnings,
2019-03-13) but delegate the sign removal so that the compilers don't
complain about taking the negative value of an unsigned value.

In addition we also rewrite the expression so that we first increment
and then negate.

The definition of remove_sign(number_unsigned_t) is never called as
unsigned values are never negative.
    @t-b
    t-b committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    6ce2f35 View commit details
    Browse the repository at this point in the history

  2. Add regression test for dumping the minimum value of int64_t

    @t-b
    t-b committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    70aa8a3 View commit details
    Browse the repository at this point in the history

  3. Add serialization unit tests for extreme integer values

    @t-b
    t-b committed Sep 3, 2019
    1 Configuration menu
    Copy the full SHA
    8067c3c View commit details
    Browse the repository at this point in the history