Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make json_pointer::back const (resolves #1764) #1769

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

chris0x44
Copy link

Added const to json_pointer::back()
Extended unit-json_pointer.cpp to make use of back() on const object.


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7476f5e on chris0x44:json_pointer into 99d7518 on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Oct 3, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Oct 3, 2019
@nlohmann nlohmann merged commit dae0fe7 into nlohmann:develop Oct 3, 2019
@nlohmann
Copy link
Owner

nlohmann commented Oct 3, 2019

Thanks!

@nlohmann
Copy link
Owner

nlohmann commented Oct 3, 2019


🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

  • json_pointer::back() is now const.

Contributor entry


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants