Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appveyor.yml: Add MSVC 16 2019 support #1780

Merged
merged 4 commits into from
Nov 2, 2019
Merged

appveyor.yml: Add MSVC 16 2019 support #1780

merged 4 commits into from
Nov 2, 2019

Conversation

t-b
Copy link
Contributor

@t-b t-b commented Oct 7, 2019 •
edited
Loading

silence bot!

@request-info
Copy link

request-info bot commented Oct 7, 2019

We would appreciate it if you could provide us with more info about this issue or pull request! Please check the issue template and the pull request template.

@request-info request-info bot added the state: needs more info the author of the issue needs to provide more details label Oct 7, 2019
@coveralls
Copy link

coveralls commented Oct 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c6cbdf9 on t-b:add-msvc-16-2019 into ed55414 on nlohmann:develop.

nlohmann
nlohmann requested changes Oct 9, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check why the AppVeyor builds are failing: https://ci.appveyor.com/project/nlohmann/json/builds/27941353?

@t-b t-b force-pushed the add-msvc-16-2019 branch 4 times, most recently from e3ce966 to 2391a04 Compare October 14, 2019 20:14
This was referenced Oct 15, 2019
Closed
Merged
@t-b t-b force-pushed the add-msvc-16-2019 branch 2 times, most recently from b05e49d to f77841e Compare October 16, 2019 07:12
@t-b
appveyor: Pass the generator platform explicitly
7a52115 
In a future commit we want to add support for MSVC 2019. For that
version cmake requires us to pass in the architecture not part of the
generator but explicitly.

So let's pass that in always like that. This also removes the doubling
of the platform/architecture.
@t-b
test/cmake_import: Pass the generator platform required by MSVC 2019
5541a2b
@t-b
Copy link
Contributor Author

t-b commented Oct 16, 2019

@nlohmann Ready

@t-b t-b requested a review from nlohmann October 17, 2019 15:53
@t-b
Copy link
Contributor Author

t-b commented Oct 29, 2019 •
edited
Loading

@nlohmann Anything still missing here?

@nlohmann nlohmann added platform: visual studio related to MSVC release item: ⚡ improvement and removed state: needs more info the author of the issue needs to provide more details labels Nov 2, 2019
@nlohmann nlohmann self-assigned this Nov 2, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Nov 2, 2019
@nlohmann nlohmann merged commit 4d1e4c6 into nlohmann:develop Nov 2, 2019
@nlohmann
Copy link
Owner

nlohmann commented Nov 2, 2019

Thanks!

@nlohmann
Copy link
Owner

nlohmann commented Nov 2, 2019

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

  • Add MSVC 16 2019 support to CI.

@t-b t-b deleted the add-msvc-16-2019 branch November 2, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
platform: visual studio related to MSVC release item: ⚡ improvement
Projects
None yet
Milestone
Release 3.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@t-b @coveralls @nlohmann