Fix for #1647 #1821
Merged
Fix for #1647 #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that (as discussed in #1647) this compile error is compiler-specific. It does not happen with e.g. Clang 10.0.0. I'm not actually sure why, I'm thinking GCC is correct here by failing to compile. |
|
Moved the test. Not sure what's up with the failure in Travis. |
|
Thanks! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #1647, which discusses a compile error when an enum is deserialized and a user-defined struct has a "non default constructible" from_json function defined for it.
The issue was a template instantiation with a
const-qualifier on the type. This pull request simply removes that qualifier.I have extended the existing enum conversion test by adding a class in an anonymous namespace. For this class a "non default constructable" from_json function is defined. The "enum" test iteself did not need to be updated. I verified that the tests no longer compiled after the addition of the new class, and did once again compile after the change in
json.hpp.