Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Fix string representation of dumped json #1979

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

alexweej
Copy link
Contributor

As is it's confusing and inconsistent with the indented form right below. The backslash escapes make it confusing.

As is it's confusing and inconsistent with the indented form right below. The backslash escapes make it confusing.
@alexweej alexweej requested a review from nlohmann as a code owner March 10, 2020 19:38
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5fdb1d0 on alex-weej:patch-2 into 973c52d on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Mar 13, 2020
@nlohmann nlohmann added this to the Release 3.7.4 milestone Mar 13, 2020
@nlohmann nlohmann merged commit d102da6 into nlohmann:develop Mar 13, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner


🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants