Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README.md. Missing ``` #2077

Merged
merged 1 commit into from
May 1, 2020
Merged

Conversation

ArthurSonzogni
Copy link
Contributor

This patch follows the one from: #2074.

An error has been introduced by accepting the suggestions. See:
ArthurSonzogni@4be4a03

One suggestion was about removing ~~~, but it was meant to be replaced
by ``` in reality. This caused the README.md to be slightly broken.

About pull request:
nlohmann#2074

An error has been introduced by accepting the suggestions:
4be4a03

One was about removing ~~~, but it was meant to be replaced by ``` in
reality. This caused the README.md to be slightly broken.
@ArthurSonzogni
Copy link
Contributor Author

Hi again,

It looks like there was a small issue in the previous patch. I blindly accepted all the suggestions, but I didn't realize one was removing ~~~ without replacing it with ```

Could you please take a look?

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this May 1, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 1, 2020
@nlohmann nlohmann merged commit 2251741 into nlohmann:develop May 1, 2020
@ArthurSonzogni
Copy link
Contributor Author

Thanks!

@nlohmann
Copy link
Owner

nlohmann commented May 1, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants