Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bleeding edge GCC to CI #2136

Merged
merged 6 commits into from
May 26, 2020

Conversation

aokellermann
Copy link
Contributor

@aokellermann aokellermann commented May 26, 2020

This PR adds CI testing for the bleeding edge release of GCC (currently GCC 10.1). This is in response to the wanted section in the contributing guidelines. I could not find an issue for this request.

Changes:

  • Adds second CircleCI job using Arch Linux docker image to run identical tests as the original.
  • Renames original CircleCI job to build_stable to be more descriptive of what it is testing.
  • Adds CircleCI workflow to run both jobs concurrently.
  • Updates documentation to reflect the addition of this compiler and CI.

Example of successful concurrent jobs:
2020-05-25-210813_3000x2160_scrot

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 49000cd on aokellermann:CircleCI_GCC_BleedingEdge into c92a696 on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit 25aab7e into nlohmann:develop May 26, 2020
@nlohmann nlohmann self-assigned this May 26, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 26, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner


🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants