Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify conversion from/to custom types #2225

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Simplify conversion from/to custom types #2225

merged 2 commits into from
Jun 29, 2020

Conversation

nlohmann
Copy link
Owner

This PR adds two macros proposed in the discussion of #2175.

Closes #2175.

@nlohmann nlohmann marked this pull request as draft June 27, 2020 11:19
@nlohmann nlohmann self-assigned this Jun 27, 2020
@nlohmann nlohmann mentioned this pull request Jun 27, 2020
Closed
pfeatherstone
pfeatherstone approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@pfeatherstone pfeatherstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

@KonanM
Copy link

KonanM commented Jun 27, 2020

Looks good to me. I'm glad that you added a proper prefix to the macros. Ship it!

@nlohmann nlohmann marked this pull request as ready for review June 27, 2020 15:35
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0fe9f23 on issue2175 into 5ba0f65 on develop.

@nlohmann nlohmann merged commit eb7376b into develop Jun 29, 2020
@nlohmann nlohmann deleted the issue2175 branch June 29, 2020 12:41
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jun 29, 2020
@nlohmann
Copy link
Owner Author

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

@nlohmann nlohmann mentioned this pull request Jun 30, 2020
Merged
@mzyy94 mzyy94 mentioned this pull request Jul 17, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeatherstone pfeatherstone pfeatherstone approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: ⚡ improvement
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

Custom type registration : instrusive API
4 participants
@nlohmann @KonanM @coveralls @pfeatherstone