Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore disabled check for #3070 (except on MSVC) #3421

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Restore disabled check for #3070 (except on MSVC) #3421

merged 1 commit into from
Apr 6, 2022

Commits on Apr 5, 2022

  1. Restore disabled check for nlohmann#3070 (except on MSVC) 

    Restore the previously disabled check for regression nlohmann#3070 on all
compilers but MSVC.

To summarize the issue:
Given namespace fs = std::filesystem.
On MSVC attempting to construct an fs::path from json results in an
ambiguous overload resolution because fs::path can be constructed from
both a std::string as well as another fs::path.
To the best of my knowledge there is no way to fix an ambiguous overload
situation involving a type we do not control and with json implicitly
converting to both std::string and fs::path.

Re-enabling the check where it compiles and keeping it disabled for MSVC
is the best we can do.

Closes nlohmann#3377 and nlohmann#3382.
    @falbrechtskirchinger
    falbrechtskirchinger committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    db1196f View commit details
    Browse the repository at this point in the history