Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #3626

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Update CI #3626

merged 4 commits into from
Aug 3, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Fixes #3612.

@coveralls
Copy link

coveralls commented Jul 29, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling cea3a07 on falbrechtskirchinger:ci-update into 817a4a2 on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@falbrechtskirchinger
Copy link
Contributor Author

One more note for you:

xcode: ['11.7', '12.4', '12.5.1', '13.0']

13.0 turns into 13 and CI fails. Seems like good practice to use strings in cases like this in the future.

@nlohmann
Copy link
Owner

nlohmann commented Aug 3, 2022

One more note for you:

xcode: ['11.7', '12.4', '12.5.1', '13.0']

13.0 turns into 13 and CI fails. Seems like good practice to use strings in cases like this in the future.

And that answers my unasked question why you added quotes around all the version numbers :-)

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 3, 2022
@nlohmann nlohmann merged commit ac9e668 into nlohmann:develop Aug 3, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the ci-update branch August 3, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS 10.15 Actions runner image deprecation
3 participants