Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for integration with CMake and hunter #671

Merged
merged 2 commits into from
Aug 1, 2017
Merged

Add documentation for integration with CMake and hunter #671

merged 2 commits into from
Aug 1, 2017

Conversation

dan-42
Copy link
Contributor

@dan-42 dan-42 commented Jul 31, 2017

here you go, as requested. I added again the LANGUAGES CXX and also added the documenation about using it with CMake and CMake with hunter.
Hunter just released his latest version with supporting the version v2.1.1 of nlohman_json 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2199131 on dan-42:develop into 850d856 on nlohmann:develop.

nlohmann
nlohmann requested changes Jul 31, 2017
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to have a too long explanation for all the different package managers. The description should be written so that people already familiar with the package managers know what to do.

README.md Outdated
[...]
hunter_add_package(nlohmann_json)
find_package(nlohmann_json CONFIG REQUIRED)
target_link_libraries(... nlohmann_json)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite verbose. Is it possible to describe this shorter as it is done for Meson, Conan, or Homebrew?

@dan-42
Copy link
Contributor Author

dan-42 commented Jul 31, 2017

Ohh ok.
So I changed it and kept it simple. Hope this is what you want?

@dan-42 dan-42 mentioned this pull request Jul 31, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db0b973 on dan-42:develop into e60002a on nlohmann:develop.

nlohmann
nlohmann approved these changes Aug 1, 2017
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit 76ecb2b into nlohmann:develop Aug 1, 2017
@nlohmann
Copy link
Owner

nlohmann commented Aug 1, 2017

Thanks a lot!

@nlohmann nlohmann self-assigned this Aug 1, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
documentation
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-42 @coveralls @nlohmann