Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forwarding references to json_ref constructor #807

Merged
merged 1 commit into from
Oct 28, 2017

Conversation

theodelrieu
Copy link
Contributor

fixes #805

One funny thing I've discovered: You cannot use friend void to_json() with a local class (class/struct defined inside a function). I'll investigate later, I remember seeing something in the standard about that.

Anyway it's not a very asked feature :)

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4b46abf on theodelrieu:fix/805 into 8e067c0 on nlohmann:develop.

@nlohmann nlohmann merged commit 73d0095 into nlohmann:develop Oct 28, 2017
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{} uses copy constructor, while = does not
3 participants