Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Services] Remote model register @open sesame 09/11 17:52 #350

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[Services] Remote model register @open sesame 09/11 17:52 #350

merged 2 commits into from
Sep 12, 2023

Conversation

gichan-jang
Copy link
Member

  • Implement registering model remotely
  • Add unit test

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 3, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #350. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@gichan-jang gichan-jang force-pushed the remote/model/register branch 2 times, most recently from 11c66c0 to dbed546 Compare July 3, 2023 08:06
taos-ci
taos-ci approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 10, 2023

:octocat: cibot: @gichan-jang, c/src/ml-api-remote-service.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 10, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/350-202307101857500.30094695091248-06b6c2d5ebda25ab79c7ec19b54feef6574e31dd/.

@gichan-jang gichan-jang force-pushed the remote/model/register branch 2 times, most recently from 25dd92f to c491549 Compare July 10, 2023 10:24
taos-ci
taos-ci approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

taos-ci
taos-ci approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang gichan-jang changed the title [Services] Remote model register [After #321][Services] Remote model register Aug 1, 2023
@taos-ci
Copy link
Collaborator

taos-ci commented Aug 1, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/350-202308011902310.8258330821991-b9c332ac7f0b0ffd565f794207824a8f7bf6b9bd/.

@gichan-jang gichan-jang changed the title [After #321][Services] Remote model register [After #321][Services] Remote model register @open sesame 08/02 10:30 Aug 2, 2023
taos-ci
taos-ci approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

songgot
songgot approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gichan-jang gichan-jang force-pushed the remote/model/register branch 2 times, most recently from 314d6a9 to 1de9782 Compare September 7, 2023 04:15
@gichan-jang gichan-jang changed the title [After #321][Services] Remote model register @open sesame 08/02 10:30 [Services] Remote model register Sep 7, 2023
taos-ci
taos-ci approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 7, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/350-202309071825350.4517560005188-3ae9826df60734ae13de206a2c7ce38424b5539f/.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 8, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/350-202309081724360.25519704818726-a38bb42dcc5246d059c5c0bb96978ecf0b8b179e/.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 8, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/350-202309081753040.89471292495728-737cd2a467e64edb6bc8ac07ba35c61a946e8b28/.

@gichan-jang gichan-jang changed the title [Services] Remote model register [Services] Remote model register @open sesame 09/11 17:52 Sep 11, 2023
@gichan-jang
[Services] Remote model register
6faf7b3 
 - Impelent registering model relotely
 - Add unit test

Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Sep 11, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/350-202309111759400.19511604309082-5832b61fbdb4831fff8883c06a539a7f8e409cb0/.

@gichan-jang
[ml-service] Move remote api to tizen-internal.
7069f2f 
Move ml-remote-service api to tizen-internal.
They are expreimental API.

Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
taos-ci
taos-ci approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@jaeyun-jung jaeyun-jung merged commit db4fd45 into nnstreamer:main Sep 12, 2023
29 checks passed
@gichan-jang gichan-jang deleted the remote/model/register branch September 18, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songgot songgot songgot approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

Assignees
No one assigned
Labels
Tizen 9.0 M2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gichan-jang @taos-ci @songgot @jaeyun-jung @again4you