[Service] active flag from json #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jaeyun-jung
commented
Oct 27, 2023
•
jaeyun-jung
commented
- Update 'activate' flag from json when registering new model info from res-pkg.
- Allow null description in json, description string is not mandatory field.
- Fix log message, hide app info string.
jaeyun-jung
requested review from
myungjoo,
jijoongmoon and
again4you
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #413. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
jaeyun-jung
force-pushed
the
model-update-active
branch
from
5f8f9e0
to
6805b0a
Compare
taos-ci
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
1. Update 'activate' flag from json when registering new model info from res-pkg. 2. Allow null description in json, description string is not mandatory field. 3. Fix log message, hide app info string. Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
jaeyun-jung
force-pushed
the
model-update-active
branch
from
6805b0a
to
f6907bf
Compare
taos-ci
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.