Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle some edge cases in scores function #148

Merged
merged 9 commits into from
Apr 11, 2024

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Mar 8, 2024

@btang1 pointed these out. These occur when all the data from either mod or obs or both is either all inside the interval or all outside.

  • add a test or two

cc: @btang1 @drnimbusrain

@zmoon zmoon marked this pull request as ready for review March 8, 2024 19:17
@zmoon zmoon requested a review from drnimbusrain March 8, 2024 19:17
monet/util/stats.py Outdated Show resolved Hide resolved
@bbakernoaa
Copy link
Member

@btang1 can you take a look at this. Go through the tests and make sure that a b c and d are being calculated correctly.

@btang1
Copy link

btang1 commented Mar 18, 2024

@btang1 can you take a look at this. Go through the tests and make sure that a b c and d are being calculated correctly.

will do~

@btang1
Copy link

btang1 commented Mar 19, 2024

@zmoon @bbakernoaa
I run 3 tests on Zach new score code (published 03/14) and the results are all good

  1. test one: run with test_score.py example code. all good.

  2. test two: run with test_score.py but set minval larger than maximum of obs and model. result all good. this is the very case we met when threshold lager than boundary.

  3. run Zach's new scores with CSI plot for AQM upgrade project. and new code results are consistent with previous version (zach Mar-10th code) result. you can find result here: https://drive.google.com/drive/folders/1foauKK28-L7gj_46j-GCGCBb-F8L5bA9?usp=share_link

  4. I figure out why my previous for loops code error. I set 'b' and 'c' reversely. after set them back, for loops code result is consistent with Zach's new code. result here: https://drive.google.com/drive/folders/1N8bVs8eC9UchZJrKt14alsjHMrllP8bU?usp=share_link

In conclusion, I run some test and all proved that Zach new version is best and ready to be published~

@zmoon zmoon merged commit 39a3fbd into noaa-oar-arl:develop Apr 11, 2024
6 checks passed
@zmoon zmoon deleted the fix/scores branch April 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants