-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support trailers #331
Support trailers #331
Conversation
Fixes #330.
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
========================================
+ Coverage 98.21% 100% +1.78%
========================================
Files 6 6
Lines 503 433 -70
Branches 153 133 -20
========================================
- Hits 494 433 -61
+ Misses 5 0 -5
+ Partials 4 0 -4
Continue to review full report at Codecov.
|
while this look fine, I haven't used trailer header before; need another pair of eyes to come in and check this is legit. |
LGTM (sorry for the tardy response, i slipped and rather fell out of our plane of existence for a while) |
I am honestly happy to merge. But it seems like major browsers are resisting this feature: whatwg/fetch#473 (see linked bug tracker) |
Switched to standard pending per #331 (comment). |
@TimothyGu What is the status of this? Whilst yes, Chrome etc have not implemented Trailer support in their fetch implementations. It is still been accepted as part of the spec and useful within server-side environments regardless of browser implementation status. Trailers have become more useful since this PR was opened due to their adoption within the Server-Timing API as a mechanism to return timing information about a response after it is closed, such as the final round-trip time etc. Firefox have also recently implemented trailer support specifically for Server-Timing: https://bugzilla.mozilla.org/show_bug.cgi?id=1413999 Therefore, would you consider reopening and merging this PR? I am happy to do the work to fix the merge conflicts etc if so :) |
Closing this, as #690 is on hold. |
Fixes #330.