Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailers #331

Closed
wants to merge 1 commit into from
Closed

Support trailers #331

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Collaborator

Fixes #330.

@codecov-io
Copy link

codecov-io commented Aug 24, 2017

Codecov Report

Merging #331 into master will increase coverage by 1.78%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #331      +/-   ##
========================================
+ Coverage   98.21%   100%   +1.78%     
========================================
  Files           6      6              
  Lines         503    433      -70     
  Branches      153    133      -20     
========================================
- Hits          494    433      -61     
+ Misses          5      0       -5     
+ Partials        4      0       -4
Impacted Files Coverage Δ
src/headers.js 100% <100%> (+3.81%) ⬆️
src/response.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (+4.87%) ⬆️
src/request.js 100% <0%> (ø) ⬆️
src/body.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed2e69...284f682. Read the comment docs.

@bitinn
Copy link
Collaborator

bitinn commented Aug 24, 2017

while this look fine, I haven't used trailer header before; need another pair of eyes to come in and check this is legit.

@TimothyGu
Copy link
Collaborator Author

TimothyGu commented Aug 25, 2017

@jkantr? @zkat?

@bitinn bitinn mentioned this pull request Sep 24, 2017
@jkantr
Copy link
Collaborator

jkantr commented Nov 29, 2017

LGTM

(sorry for the tardy response, i slipped and rather fell out of our plane of existence for a while)

@bitinn
Copy link
Collaborator

bitinn commented Nov 29, 2017

I am honestly happy to merge.

But it seems like major browsers are resisting this feature:

whatwg/fetch#473 (see linked bug tracker)

@TimothyGu
Copy link
Collaborator Author

Switched to standard pending per #331 (comment).

@phamann
Copy link

phamann commented Dec 14, 2018

@TimothyGu What is the status of this?

Whilst yes, Chrome etc have not implemented Trailer support in their fetch implementations. It is still been accepted as part of the spec and useful within server-side environments regardless of browser implementation status.

Trailers have become more useful since this PR was opened due to their adoption within the Server-Timing API as a mechanism to return timing information about a response after it is closed, such as the final round-trip time etc.

Firefox have also recently implemented trailer support specifically for Server-Timing: https://bugzilla.mozilla.org/show_bug.cgi?id=1413999

Therefore, would you consider reopening and merging this PR? I am happy to do the work to fix the merge conflicts etc if so :)

@xxczaki
Copy link
Member

xxczaki commented Nov 6, 2019

Closing this, as #690 is on hold.

@xxczaki xxczaki closed this Nov 6, 2019
@gr2m gr2m deleted the trailers branch June 11, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support trailers
7 participants