-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use modern Streams API #531
Conversation
This comment has been minimized.
This comment has been minimized.
This pull request introduces 1 alert and fixes 2 when merging 2f9191d into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
end does not return errors, use 'error' event instead write does not return length anymore
This pull request introduces 1 alert and fixes 2 when merging 214708a into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging b688b66 into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging 308dfa0 into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
removed a memory leak in the process |
This pull request introduces 1 alert and fixes 2 when merging c4f8d7b into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging dd4a9d5 into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging bf10f2f into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging e9f226d into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging 3f392e1 into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging 40b830e into b04b5ac - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Btw, it's interesting why tests getting more time to pass than these in master? Anyway, I'll merge it and continue. tests are fricking nightmare... |
This pull request introduces 1 alert and fixes 1 when merging 3d0b96d into a26cdac - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
This pull request introduces 1 alert and fixes 1 when merging 0bd03a1 into a26cdac - view on LGTM.com new alerts:
fixed alerts:
|
Many questions but I don't know, I am glad you stepped in again. |
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Anyway, I just ignored the problems. Will merge it and continue with other stuff - maybe switch to Jest, at least, seems easy ;d. |
This pull request introduces 1 alert and fixes 1 when merging 1bef152 into a26cdac - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
This pull request introduces 1 alert and fixes 1 when merging c1911af into a26cdac - view on LGTM.com new alerts:
fixed alerts:
|
Seems like the problem is that it doesn't emit |
as mentioned here #531 (comment) Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
@all-contributors please add @GrosSacASac for code, doc, bug, maintenance and financial |
I've put up a pull request to add @GrosSacASac! 🎉 |
@all-contributors please add @GrosSacASac for the Streams API idea & upgrade |
I've put up a pull request to add @GrosSacASac! 🎉 |
@all-contributors please add @GrosSacASac for code, bug, maintenance, financial and review |
I've put up a pull request to add @GrosSacASac! 🎉 |
No description provided.