Merge pull request #1786 from nodeSolidServer/CxRes-patch-set-status-…

…code fix: Return 201 when PATCH creates a new resource
nodeSolidServer · Aug 28, 2024 · f5b2b5c · f5b2b5c
2 parents 843c771 + a69da13
commit f5b2b5c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/lib/handlers/patch.js b/lib/handlers/patch.js
@@ -91,7 +91,8 @@ async function patchHandler (req, res, next) {
       return writeGraph(graph, resource, ldp.resourceMapper.resolveFilePath(req.hostname), ldp.serverUri)
     })
 
-    // Send the result to the client
+    // Send the status and result to the client
+    res.status(resourceExists ? 200 : 201)
     res.send(result)
   } catch (err) {
     return next(err)

diff --git a/test/integration/acl-oidc-test.js b/test/integration/acl-oidc-test.js
@@ -557,7 +557,7 @@ describe('ACL with WebID+OIDC over HTTP', function () {
       options.headers['content-type'] = 'application/sparql-update'
       request.patch(options, function (error, response, body) {
         assert.equal(error, null)
-        assert.equal(response.statusCode, 200)
+        assert.equal(response.statusCode, 201)
         done()
       })
     })
@@ -616,7 +616,7 @@ describe('ACL with WebID+OIDC over HTTP', function () {
       options.headers['content-type'] = 'application/sparql-update'
       request.patch(options, function (error, response, body) {
         assert.equal(error, null)
-        assert.equal(response.statusCode, 200)
+        assert.equal(response.statusCode, 201)
         done()
       })
     })

diff --git a/test/integration/patch-sparql-update-test.js b/test/integration/patch-sparql-update-test.js
@@ -22,7 +22,7 @@ describe('PATCH through application/sparql-update', function () {
     server.patch('/notExisting.ttl')
       .set('content-type', 'application/sparql-update')
       .send('INSERT DATA { :test  :hello 456 .}')
-      .expect(200)
+      .expect(201)
       .end(function (err, res, body) {
         assert.equal(
           read('sampleContainer/notExisting.ttl'),

diff --git a/test/integration/patch-test.js b/test/integration/patch-test.js
@@ -79,7 +79,7 @@ describe('PATCH through text/n3', () => {
       patch: `<> a solid:InsertDeletePatch;
                  solid:inserts { <x> <y> <z>. }.`
     }, { // expected:
-      status: 200,
+      status: 201,
       text: 'Patch applied successfully',
       result: '@prefix : </new.ttl#>.\n@prefix tim: </>.\n\ntim:x tim:y tim:z.\n\n'
     }))
@@ -90,7 +90,7 @@ describe('PATCH through text/n3', () => {
       patch: `<> a solid:InsertDeletePatch;
                  solid:inserts { <x> <y> <z>. }.`
     }, { // expected:
-      status: 200,
+      status: 201,
       text: 'Patch applied successfully',
       // result: '{\n  "@id": "/x",\n  "/y": {\n    "@id": "/z"\n  }\n}'
       result: `{
@@ -110,7 +110,7 @@ describe('PATCH through text/n3', () => {
       patch: `<> a solid:InsertDeletePatch;
                  solid:inserts { <x> <y> <z>. }.`
     }, { // expected:
-      status: 200,
+      status: 201,
       text: 'Patch applied successfully',
       result: `<rdf:RDF
  xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
@@ -126,7 +126,7 @@ describe('PATCH through text/n3', () => {
       patch: `<> a solid:InsertDeletePatch;
                  solid:inserts { <x> <y> <z>. }.`
     }, { // expected:
-      status: 200,
+      status: 201,
       text: 'Patch applied successfully',
       result: '@prefix : </new.n3#>.\n@prefix tim: </>.\n\ntim:x tim:y tim:z.\n\n'
     }))
@@ -186,7 +186,7 @@ describe('PATCH through text/n3', () => {
       patch: `<> a solid:InsertDeletePatch;
         solid:inserts { <x> <y> <z>. }.`
     }, {
-      status: 200,
+      status: 201,
       text: 'Patch applied successfully',
       result: '@prefix : <#>.\n@prefix fol: <./>.\n\nfol:x fol:y fol:z.\n\n'
     }))