Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect permissions on SHASUMS256.txt.asc and SHASUMS256.txt.sig for v12.9.1 #1904

Closed
MylesBorins opened this issue Aug 26, 2019 · 2 comments

Comments

@MylesBorins
Copy link
Contributor

https://nodejs.org/dist/v12.9.1/SHASUMS256.txt.asc
https://nodejs.org/dist/v12.9.1/SHASUMS256.txt.sig

These files were serving as a 403 forbidden from nginx as permissions were set to 600.

I ssh'd into the dist server and manually chmod'd to 644 and the files and now things are working. Would be good to do a post mortem and find out why to avoid manual intervention in the future

@rvagg
Copy link
Member

rvagg commented Aug 28, 2019

Good thinking re the fix.

I think I know what's going on. We have careful permissions fixing for all of the assets @

find "${dstdir}/${version}" -type f -exec chmod 644 '{}' \;
find "${dstdir}/${version}" -type d -exec chmod 755 '{}' \;

But that doesn't include what you, as the releaser, push up afterward, which is the .asc and .sig files. So it'll depend entirely on what your local default permissions configuration is. I guess @targos had a setup that made them 600 and they were just pushed up with no modification.

Have put up nodejs/node#29350 to try and address this, doing the permission change on the server rather than locally and relying on scp to get it right. It's an extra ssh but should be quick enough.

@targos
Copy link
Member

targos commented Aug 28, 2019

it's weird, because I always release with the same machine and it's the first time that happens.

MylesBorins pushed a commit to nodejs/node that referenced this issue Jan 16, 2020
Fixes: nodejs/build#1904

PR-URL: #29350
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit to nodejs/node that referenced this issue Mar 14, 2020
Fixes: nodejs/build#1904

PR-URL: #29350
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit to nodejs/node that referenced this issue Mar 17, 2020
Fixes: nodejs/build#1904

PR-URL: #29350
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants