chakrashim: shim new API calls

* Added `Context::AllowCodeGenerationFromStrings` * Added `Isolate::SetAllowWasmCodeGenerationCallback` and `AllowWasmCodeGenerationCallback`
nodejs · Mar 19, 2018 · 398a1ea · 398a1ea
1 parent ced0471
commit 398a1ea
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -2534,6 +2534,9 @@ class V8_EXPORT MicrotasksScope {
     MicrotasksScope& operator=(const MicrotasksScope&) = delete;
 };
 
+typedef bool (*AllowWasmCodeGenerationCallback)(Local<Context> context,
+                                                Local<String> source);
+
 enum GCType {
   kGCTypeScavenge = 1 << 0,
   kGCTypeMarkSweepCompact = 1 << 1,
@@ -2804,6 +2807,8 @@ class V8_EXPORT Isolate {
   void SetCaptureStackTraceForUncaughtExceptions(
       bool capture, int frame_limit = 10,
       StackTrace::StackTraceOptions options = StackTrace::kOverview);
+  void SetAllowWasmCodeGenerationCallback(
+      AllowWasmCodeGenerationCallback callback);
 };
 
 class V8_EXPORT JitCodeEvent {
@@ -2986,6 +2991,7 @@ class V8_EXPORT Context {
   Local<Value> GetEmbedderData(int index);
   void SetSecurityToken(Handle<Value> token);
   Handle<Value> GetSecurityToken();
+  void AllowCodeGenerationFromStrings(bool allow);
 };
 
 class V8_EXPORT Locker {

diff --git a/deps/chakrashim/src/v8context.cc b/deps/chakrashim/src/v8context.cc
@@ -159,4 +159,8 @@ Handle<Value> Context::GetSecurityToken() {
   return Handle<Value>();
 }
 
+void Context::AllowCodeGenerationFromStrings(bool allow) {
+  // CHAKRA-TODO
+}
+
 }  // namespace v8
diff --git a/deps/chakrashim/src/v8isolate.cc b/deps/chakrashim/src/v8isolate.cc
@@ -272,6 +272,11 @@ bool Isolate::GetHeapSpaceStatistics(HeapSpaceStatistics* space_statistics,
   return true;
 }
 
+void Isolate::SetAllowWasmCodeGenerationCallback(
+    AllowWasmCodeGenerationCallback callback) {
+  // CHAKRA-TODO: Figure out what to do here
+}
+
 Isolate::DisallowJavascriptExecutionScope::DisallowJavascriptExecutionScope(
   Isolate* isolate,
   OnFailure on_failure) {