chore: increase test timeouts to avoid flaky tests #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 37 37
Lines 4065 4065
=======================================
Hits 3420 3420
Misses 645 645 Continue to review full report at Codecov.
|
mocha defaults to a 2000ms timeout, which frequently causes CI to fail. Since such short timeouts are pretty much useless, vastly increase the timeout to one minute per test.
tniessen
force-pushed
the
short-timeouts-are-useless
branch
from
f146809
to
e7fd056
Compare
tniessen
changed the title
targos
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mocha defaults to a 2000ms timeout, which frequently causes CI to fail.
Since such short timeouts are pretty much useless, vastly increase the
timeout to one minute per test.