Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

test-http-dns-fail.js failing on Jenkins #25858

Closed
misterdjules opened this issue Aug 13, 2015 · 6 comments
Closed

test-http-dns-fail.js failing on Jenkins #25858

misterdjules opened this issue Aug 13, 2015 · 6 comments

Comments

@misterdjules
Copy link

test-http-dns-fail.js was in the list of flaky tests at some point, and then got removed from the list of flaky tests when all Jenkins agent stopped using the specific DNS server(s) that do not respond with an error when trying to resolve a clearly invalid hostname.

Now that we started using the CI platform at jenkins-iojs.nodesource.com, some of the Jenkins agents that this platform uses still trigger a failure for this test. It could be because these agents are still configured to use these "faulty" DNS servers.

@orangemocha @joaocgreis @jbergstroem @rvagg Would you mind checking if these SmartOS CI agents still have 4.2.2.2 in /etc/resolv.conf? I currently can't access a shell on these agents.

@joaocgreis
Copy link
Member

I added 4.2.2.2 in the 32 bit Smart OS machine (was already there in the 64 bit one).

@joaocgreis
Copy link
Member

... but that was not the machine where the test failed. Let me try to run it manually there.

@joaocgreis
Copy link
Member

@misterdjules @orangemocha Ok, the objective was to remove it, not add it. Sorry for the confusion, it is fixed now and works.

@jbergstroem @rvagg on the 64 bit machine, there was also a 216.52.1.1 server in /etc/resolv.conf, because of it the test took 1 full minute to complete. I commented that line. Is it ok to remove completely or was there for some reason?

@misterdjules
Copy link
Author

@joaocgreis Thank you 👍 Can we close this issue then?

@jbergstroem
Copy link
Member

@joaocgreis not sure where that came from. Happy to let it go.

@joaocgreis
Copy link
Member

@jbergstroem ok, preparing PR.

@misterdjules sure, seems all ok now.

joaocgreis added a commit to JaneaSystems/build that referenced this issue Aug 17, 2015
DNS tests are sensible to which DNS servers are used. Google DNS servers
are known to work and should provide a stable DNS environment to run the
tests.

Fixes: nodejs/node-v0.x-archive#25858
joaocgreis added a commit to JaneaSystems/build that referenced this issue Aug 17, 2015
DNS tests are sensible to which DNS servers are used. Google DNS servers
are known to work and should provide a stable DNS environment to run the
tests.

Fixes: nodejs/node-v0.x-archive#25858
Fixes: nodejs#155
joaocgreis added a commit to JaneaSystems/build that referenced this issue Aug 21, 2015
DNS tests are sensible to which DNS servers are used. Google DNS servers
are known to work and should provide a stable DNS environment to run the
tests.

Fixes: nodejs/node-v0.x-archive#25858
Fixes: nodejs#155
PR-URL: nodejs#156
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants