Skip to content

Commit

Permalink
test: use const/let and common.mustCall
Browse files Browse the repository at this point in the history
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.

PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
  • Loading branch information
outsideris authored and targos committed Dec 28, 2016
1 parent 3f7d7f5 commit 1acb95d
Showing 1 changed file with 15 additions and 21 deletions.
36 changes: 15 additions & 21 deletions test/parallel/test-tls-cnnic-whitelist.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}

var tls = require('tls');
var fs = require('fs');
var path = require('path');
var finished = 0;
const assert = require('assert');
const tls = require('tls');
const fs = require('fs');
const path = require('path');

function filenamePEM(n) {
return path.join(common.fixturesDir, 'keys', n + '.pem');
Expand All @@ -20,7 +19,7 @@ function loadPEM(n) {
return fs.readFileSync(filenamePEM(n));
}

var testCases = [
const testCases = [
{ // Test 0: for the check of a cert not existed in the whitelist.
// agent7-cert.pem is issued by the fake CNNIC root CA so that its
// hash is not listed in the whitelist.
Expand Down Expand Up @@ -58,27 +57,22 @@ var testCases = [
];

function runTest(tindex) {
var tcase = testCases[tindex];
const tcase = testCases[tindex];

if (!tcase) return;

var server = tls.createServer(tcase.serverOpts, function(s) {
const server = tls.createServer(tcase.serverOpts, (s) => {
s.resume();
}).listen(0, function() {
}).listen(0, common.mustCall(function() {
tcase.clientOpts = this.address().port;
var client = tls.connect(tcase.clientOpts);
client.on('error', function(e) {
const client = tls.connect(tcase.clientOpts);
client.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, tcase.errorCode);
server.close(function() {
finished++;
server.close(common.mustCall(() => {
runTest(tindex + 1);
});
});
});
}));
}));
}));
}

runTest(0);

process.on('exit', function() {
assert.equal(finished, testCases.length);
});

0 comments on commit 1acb95d

Please sign in to comment.