Skip to content

Commit

Permalink
test: remove timer in test-dgram-send-empty-array
Browse files Browse the repository at this point in the history
The timer is not necessary. The test will timeout via the test harness
if the test fails. This should resolve spurious CI failures.

PR-URL: #9361
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and Myles Borins committed Nov 22, 2016
1 parent 7b60288 commit 2c056a4
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions test/parallel/test-dgram-send-empty-array.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,9 @@ if (common.isOSX) {

const client = dgram.createSocket('udp4');

const timer = setTimeout(function() {
throw new Error('Timeout');
}, common.platformTimeout(200));

client.on('message', common.mustCall(function onMessage(buf, info) {
const expected = Buffer.alloc(0);
assert.ok(buf.equals(expected), 'message was received correctly');
clearTimeout(timer);
client.close();
}));

Expand Down

0 comments on commit 2c056a4

Please sign in to comment.