Skip to content

Commit

Permalink
test: add missing tmpdir.refresh() in recently-added test
Browse files Browse the repository at this point in the history
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: #24913 (comment)

PR-URL: #25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Dec 25, 2018
1 parent a9ab28d commit 3e1fe19
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/parallel/test-child-process-spawn-args.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const { spawn } = require('child_process');
const common = require('../common');
const tmpdir = require('../common/tmpdir');

tmpdir.refresh();

const command = common.isWindows ? 'cd' : 'pwd';
const options = { cwd: tmpdir.path };

Expand Down

0 comments on commit 3e1fe19

Please sign in to comment.