Skip to content

Commit

Permalink
deps: V8: cherry-pick 4e1bf2bc92bd
Browse files Browse the repository at this point in the history
Original commit message:

    Skip InterpreterWithNativeStack on jitless mode

    As discussed under https://crrev.com/c/1981505,
    Test requires an executable CODE_SPACE and is thus incompatible with
    jitless mode.

    Change-Id: Icddad50a3484f0cfc5fb4abd7175058d50bc06d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193911
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67726}

Refs: v8/v8@4e1bf2b

PR-URL: #33702
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
Milad Farazmand authored and codebytere committed Jun 18, 2020
1 parent 0524c7a commit 499c740
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.20',
'v8_embedder_string': '-node.22',

##### V8 defaults for Node.js #####

Expand Down
1 change: 1 addition & 0 deletions deps/v8/test/cctest/cctest.status
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,7 @@
'test-log/LogInterpretedFramesNativeStack': [SKIP],
'test-log/LogInterpretedFramesNativeStackWithSerialization': [SKIP],
'test-serialize/CodeSerializerOnePlusOneWithInterpretedFramesNativeStack': [SKIP],
'test-interpreter/InterpreterWithNativeStack': [SKIP],

# Crashes on native arm.
'test-macro-assembler-arm/ExtractLane': [PASS, ['arch == arm and not simulator_run', SKIP]],
Expand Down

0 comments on commit 499c740

Please sign in to comment.