Skip to content

Commit

Permalink
test: refactor addons-napi/test_promise/test.js
Browse files Browse the repository at this point in the history
* remove custom messages for assert that conceal values
* add comment explaining test
* add block scoping

PR-URL: #16814
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
ka3e authored and Trott committed Nov 13, 2017
1 parent b204b09 commit 51f92b6
Showing 1 changed file with 17 additions and 14 deletions.
31 changes: 17 additions & 14 deletions test/addons-napi/test_promise/test.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
'use strict';

const common = require('../../common');
const test_promise = require(`./build/${common.buildType}/test_promise`);

// This tests the promise-related n-api calls

const assert = require('assert');
const test_promise = require(`./build/${common.buildType}/test_promise`);

// A resolution
{
const expected_result = 42;
const promise = test_promise.createPromise();
promise.then(
common.mustCall(function(result) {
assert.strictEqual(result, expected_result,
`promise resolved as expected, received ${result}`);
assert.strictEqual(result, expected_result);
}),
common.mustNotCall());
test_promise.concludeCurrentPromise(expected_result, true);
Expand All @@ -24,23 +26,24 @@ const assert = require('assert');
promise.then(
common.mustNotCall(),
common.mustCall(function(result) {
assert.strictEqual(result, expected_result,
`promise rejected as expected, received ${result}`);
assert.strictEqual(result, expected_result);
}));
test_promise.concludeCurrentPromise(expected_result, false);
}

// Chaining
const promise = test_promise.createPromise();
promise.then(
common.mustCall(function(result) {
assert.strictEqual(result, 'chained answer',
'resolving with a promise chains properly');
}),
common.mustNotCall());
test_promise.concludeCurrentPromise(Promise.resolve('chained answer'), true);
{
const expected_result = 'chained answer';
const promise = test_promise.createPromise();
promise.then(
common.mustCall(function(result) {
assert.strictEqual(result, expected_result);
}),
common.mustNotCall());
test_promise.concludeCurrentPromise(Promise.resolve('chained answer'), true);
}

assert.strictEqual(test_promise.isPromise(promise), true);
assert.strictEqual(test_promise.isPromise(test_promise.createPromise()), true);
assert.strictEqual(test_promise.isPromise(Promise.reject(-1)), true);
assert.strictEqual(test_promise.isPromise(2.4), false);
assert.strictEqual(test_promise.isPromise('I promise!'), false);
Expand Down

0 comments on commit 51f92b6

Please sign in to comment.