-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
errors: annotate frames for prepareStackTrace()
When source-maps are enabled, overriding Error.prepareStackTrace() is again supported. Error.prepareStackTrace() will now be passed stack frames with the methods getOriginalFileName(), getOriginalLineNumber(), and getOriginalColumnNumber() which provide information parsed from source map.
- Loading branch information
Showing
2 changed files
with
90 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
// Flags: --enable-source-maps | ||
'use strict'; | ||
|
||
require('../common'); | ||
const assert = require('assert'); | ||
|
||
// Error.prepareStackTrace() can be overridden with source maps enabled. | ||
{ | ||
let prepareCalled = false; | ||
Error.prepareStackTrace = (_error, trace) => { | ||
prepareCalled = true; | ||
}; | ||
try { | ||
throw new Error('foo'); | ||
} catch (err) { | ||
err.stack; | ||
} | ||
assert(prepareCalled); | ||
} | ||
|
||
// Error.prepareStackTrace() should expose getOriginalLineNumber(), | ||
// getOriginalColumnNumber(), getOriginalFileName(). | ||
{ | ||
let callSite; | ||
Error.prepareStackTrace = (_error, trace) => { | ||
const throwingRequireCallSite = trace[0]; | ||
if (throwingRequireCallSite.getFileName().endsWith('typescript-throw.js')) { | ||
callSite = throwingRequireCallSite; | ||
} | ||
}; | ||
try { | ||
// Require a file that throws an exception, and has a source map. | ||
require('../fixtures/source-map/typescript-throw.js'); | ||
} catch (err) { | ||
err.stack; // Force prepareStackTrace() to be called. | ||
} | ||
assert(callSite); | ||
|
||
assert(callSite.getFileName().endsWith('typescript-throw.js')); | ||
assert(callSite.getOriginalFileName().endsWith('typescript-throw.ts')); | ||
|
||
assert.strictEqual(callSite.getLineNumber(), 20); | ||
assert.strictEqual(callSite.getColumnNumber(), 15); | ||
|
||
assert.strictEqual(callSite.getOriginalLineNumber(), 18); | ||
assert.strictEqual(callSite.getOriginalColumnNumber(), 11); | ||
} |