Skip to content

Commit

Permalink
test: refactor test-https-truncate
Browse files Browse the repository at this point in the history
Changes assert.equal to assert.strictEqual to ensure specificity.

Changes var declarations to const/let where appropriate.

PR-URL: #10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information
davidmarkclements authored and addaleax committed Dec 8, 2016
1 parent d698f9d commit 9b7d748
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions test/parallel/test-https-truncate.js
Original file line number Diff line number Diff line change
@@ -1,34 +1,34 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var https = require('https');
const https = require('https');

var fs = require('fs');
const fs = require('fs');

var key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
var cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');
const key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
const cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');

// number of bytes discovered empirically to trigger the bug
var data = Buffer.allocUnsafe(1024 * 32 + 1);
const data = Buffer.allocUnsafe(1024 * 32 + 1);

httpsTest();

function httpsTest() {
var sopt = { key: key, cert: cert };
const sopt = { key: key, cert: cert };

var server = https.createServer(sopt, function(req, res) {
const server = https.createServer(sopt, function(req, res) {
res.setHeader('content-length', data.length);
res.end(data);
server.close();
});

server.listen(0, function() {
var opts = { port: this.address().port, rejectUnauthorized: false };
const opts = { port: this.address().port, rejectUnauthorized: false };
https.get(opts).on('response', function(res) {
test(res);
});
Expand All @@ -38,14 +38,14 @@ function httpsTest() {

function test(res) {
res.on('end', function() {
assert.equal(res._readableState.length, 0);
assert.equal(bytes, data.length);
assert.strictEqual(res._readableState.length, 0);
assert.strictEqual(bytes, data.length);
console.log('ok');
});

// Pause and then resume on each chunk, to ensure that there will be
// a lone byte hanging out at the very end.
var bytes = 0;
let bytes = 0;
res.on('data', function(chunk) {
bytes += chunk.length;
this.pause();
Expand Down

0 comments on commit 9b7d748

Please sign in to comment.