Address review comments

nodejs · Jan 13, 2021 · efd2b91 · efd2b91
1 parent 2ca9712
commit efd2b91
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -124,8 +124,9 @@ function randomFill(buf, offset, size, callback) {
 // e.g.: Buffer.from("ff".repeat(6), "hex").readUIntBE(0, 6);
 const RAND_MAX = 0xFFFF_FFFF_FFFF;
 
-// Cache random data to use in randomInt.
-const randomCache = new FastBuffer(3072);
+// Cache random data to use in randomInt. The cache size must be evenly
+// divisible by 6 because each attempt to obtain a random int uses 6 bytes.
+const randomCache = new FastBuffer(6 * 1024);
 let randomCacheOffset = randomCache.length;
 let asyncCacheFillInProgress = false;
 const asyncCachePendingTasks = [];