lib: use kResistStopPropagation

nodejs · Jun 25, 2023 · fc1e0ad · fc1e0ad
1 parent 0741f5a
commit fc1e0ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js
@@ -23,6 +23,7 @@ const {
   kTrustEvent,
   kNewListener,
   kRemoveListener,
+  kResistStopPropagation,
   kWeakHandler,
 } = require('internal/event_target');
 const {
@@ -435,7 +436,8 @@ async function aborted(signal, resource) {
   if (signal.aborted)
     return PromiseResolve();
   const abortPromise = createDeferredPromise();
-  signal.addEventListener('abort', abortPromise.resolve, { [kWeakHandler]: resource, once: true });
+  const opts = { __proto__: null, [kWeakHandler]: resource, once: true, [kResistStopPropagation]: true };
+  signal.addEventListener('abort', abortPromise.resolve, opts);
   return abortPromise.promise;
 }
 

diff --git a/lib/internal/watch_mode/files_watcher.js b/lib/internal/watch_mode/files_watcher.js
@@ -18,6 +18,7 @@ const { fileURLToPath } = require('url');
 const { resolve, dirname } = require('path');
 const { setTimeout } = require('timers');
 
+let kResistStopPropagation;
 
 const supportsRecursiveWatching = process.platform === 'win32' ||
   process.platform === 'darwin';
@@ -41,7 +42,11 @@ class FilesWatcher extends EventEmitter {
     this.#mode = mode;
     this.#signal = signal;
 
-    signal?.addEventListener('abort', () => this.clear(), { __proto__: null, once: true });
+    if (signal) {
+      kResistStopPropagation ??= require('internal/event_target').kResistStopPropagation;
+      const opts = { __proto__: null, once: true, [kResistStopPropagation]: true };
+      signal?.addEventListener('abort', () => this.clear(), opts);
+    }
   }
 
   #isPathWatched(path) {