Skip to content

Commit

Permalink
build: remove Python 2 workaround
Browse files Browse the repository at this point in the history
Remove workaround for Python 2.

I confirmed that V8 build still works by running `./configure.py &&
make v8`.

PR-URL: #41357
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
  • Loading branch information
Trott authored and danielleadams committed Feb 1, 2022
1 parent 66556b3 commit ff48705
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@
import bz2
import io

# Fallback to find_executable from distutils.spawn is a stopgap for
# supporting V8 builds, which do not yet support Python 3.
try:
from shutil import which
except ImportError:
from distutils.spawn import find_executable as which
from distutils.version import StrictVersion

# If not run from node/, cd to node/.
Expand Down Expand Up @@ -1864,7 +1858,7 @@ def make_bin_override():
# sys.executable. This directory will be prefixed to the PATH, so that
# other tools that shell out to `python` will use the appropriate python

which_python = which('python')
which_python = shutil.which('python')
if (which_python and
os.path.realpath(which_python) == os.path.realpath(sys.executable)):
return
Expand Down

0 comments on commit ff48705

Please sign in to comment.