Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: http response.getHeader() documentation partially incorrect #10803

Closed
mscdex opened this issue Jan 14, 2017 · 0 comments
Closed

doc: http response.getHeader() documentation partially incorrect #10803

mscdex opened this issue Jan 14, 2017 · 0 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. http Issues or PRs related to the http subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jan 14, 2017 •
edited
Loading

  • Version: v4.x-master
  • Platform: n/a
  • Subsystem: doc

The http documentation incorrectly states that response.getHeader() "can only be called before headers get implicitly flushed," which is not true (AFAICT) and we explicitly even test for the ability to safely call response.getHeader() after the headers/response is written. I think this sentence can be removed entirely from the http documentation.
@mscdex mscdex added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. http Issues or PRs related to the http subsystem. labels Jan 14, 2017
@fhalde fhalde mentioned this issue Jan 15, 2017
Closed
2 tasks
fhalde added a commit to fhalde/node that referenced this issue Jan 16, 2017
@fhalde
doc: HTTP response getHeader doc fix
77c2edd 
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.
jasnell pushed a commit that referenced this issue Jan 18, 2017
@fhalde @jasnell
doc: HTTP response getHeader doc fix
90a2bb5 
According to #10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: #10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 18, 2017
@fhalde @italoacasas
doc: HTTP response getHeader doc fix
322d815 
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: nodejs#10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 23, 2017
@fhalde @italoacasas
doc: HTTP response getHeader doc fix
714e04b 
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: nodejs#10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 25, 2017
@fhalde @italoacasas
doc: HTTP response getHeader doc fix
ebf4ab7 
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: nodejs#10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 27, 2017
@fhalde @italoacasas
doc: HTTP response getHeader doc fix
9d91bf9 
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: nodejs#10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 8, 2017
@fhalde @MylesBorins
doc: HTTP response getHeader doc fix
f6f3fa0 
According to #10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: #10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 9, 2017
@fhalde @MylesBorins
doc: HTTP response getHeader doc fix
5118e05 
According to #10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: #10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @italoacasas