Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple segmentation faults in contextify when parsing options #12369

Closed
tniessen opened this issue Apr 12, 2017 · 0 comments
Closed

Multiple segmentation faults in contextify when parsing options #12369

tniessen opened this issue Apr 12, 2017 · 0 comments
Labels
vm Issues and PRs related to the vm subsystem.

Comments

@tniessen
Copy link
Member

  • Version: v6.9.2
  • Platform: all
  • Subsystem: vm, contextify

There are multiple issues in node_contextify.cc leading to possible segmentation faults when parsing user-specified options:

node
> vm.createScript('', { get lineOffset() { throw new Error(); } })
Segmentation fault
tniessen added a commit to tniessen/node that referenced this issue Apr 12, 2017
@tniessen
os,contextify: fix segfaults and CHECK failure
225fd64 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: nodejs#12369
Fixes: nodejs#12370
@tniessen tniessen mentioned this issue Apr 12, 2017
Closed
3 tasks
@mscdex mscdex added the vm Issues and PRs related to the vm subsystem. label Apr 13, 2017
evanlucas pushed a commit that referenced this issue Apr 25, 2017
@tniessen @evanlucas
os,vm: fix segfaults and CHECK failure
cf6c29c 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: #12369
Fixes: #12370
PR-URL: #12371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this issue May 1, 2017
@tniessen @evanlucas
os,vm: fix segfaults and CHECK failure
354df94 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: #12369
Fixes: #12370
PR-URL: #12371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this issue May 2, 2017
@tniessen @evanlucas
os,vm: fix segfaults and CHECK failure
6998e80 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: #12369
Fixes: #12370
PR-URL: #12371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
tniessen added a commit to tniessen/node that referenced this issue Jun 22, 2017
@tniessen
os,vm: fix segfaults and CHECK failure
408d69b 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: nodejs#12369
Fixes: nodejs#12370
PR-URL: nodejs#12371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@tniessen tniessen mentioned this issue Jun 22, 2017
Closed
4 tasks
MylesBorins pushed a commit that referenced this issue Jul 10, 2017
@tniessen @MylesBorins
os,vm: fix segfaults and CHECK failure
c29063d 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: #12369
Fixes: #12370
Backport-PR-URL: #13871
PR-URL: #12371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this issue Jul 11, 2017
@tniessen @MylesBorins
os,vm: fix segfaults and CHECK failure
47e7020 
Fixes multiple possible segmentation faults in node_contextify.cc and
an assertion failure in node_os.cc

Fixes: #12369
Fixes: #12370
Backport-PR-URL: #13871
PR-URL: #12371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

os,contextify: fix segfaults and CHECK failure tniessen/node
2 participants
@mscdex @tniessen