Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test-crypto-classes timeout on Raspberry Pi #15655

Closed
BridgeAR opened this issue Sep 28, 2017 · 2 comments
Closed

test: test-crypto-classes timeout on Raspberry Pi #15655

BridgeAR opened this issue Sep 28, 2017 · 2 comments
Labels
crypto Issues and PRs related to the crypto subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@BridgeAR
Copy link
Member

This timed out multiple times on Raspberry Pi. Ping @bengl

https://ci.nodejs.org/job/node-test-binary-arm/10431/RUN_SUBSET=3,label=pi2-raspbian-wheezy/console
https://ci.nodejs.org/job/node-test-binary-arm/10437/RUN_SUBSET=3,label=pi3-raspbian-jessie/console
https://ci.nodejs.org/job/node-test-binary-arm/10430/RUN_SUBSET=6,label=pi1-raspbian-wheezy/console

not ok 42 parallel/test-crypto-classes
  ---
  duration_ms: 240.40
  severity: fail
  stack: |-
    timeout
@BridgeAR BridgeAR added flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. labels Sep 28, 2017
@bengl
Copy link
Member

bengl commented Sep 28, 2017

It turns out the test does take some time. I'm investigating.

bengl added a commit to bengl/node that referenced this issue Sep 28, 2017
@bengl
test: fix flaky test-crypto-classes.js
fd666cd 
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Fixes: nodejs#15655
@bengl bengl mentioned this issue Sep 28, 2017
Closed
3 tasks
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Sep 28, 2017
@mhdawson
Copy link
Member

Failures here as well:

https://ci.nodejs.org/job/node-test-binary-arm/10479/RUN_SUBSET=3,label=pi1-raspbian-wheezy/console
https://ci.nodejs.org/job/node-test-commit-arm/12387/nodes=armv7-wheezy/

@mhdawson mhdawson mentioned this issue Sep 29, 2017
Closed
3 tasks
@jasnell jasnell closed this as completed in 3e4f34c Oct 1, 2017
addaleax pushed a commit to addaleax/ayo that referenced this issue Oct 4, 2017
@bengl @addaleax
test: fix flaky test-crypto-classes.js
d86e347 
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

PR-URL: nodejs/node#15662
Fixes: nodejs/node#15655
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
bengl added a commit to bengl/node that referenced this issue Oct 17, 2017
@bengl
test: fix flaky test-crypto-classes.js
367116e 
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

PR-URL: nodejs#15662
Fixes: nodejs#15655
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
evanlucas pushed a commit that referenced this issue Oct 23, 2017
@bengl @evanlucas
test: fix flaky test-crypto-classes.js
e0e5c89 
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 16, 2018
@bengl @MylesBorins
test: fix flaky test-crypto-classes.js
f1f3377 
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 17, 2018
@bengl @MylesBorins
test: fix flaky test-crypto-classes.js
542f13f 
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 12, 2018
@bengl @MylesBorins
test: fix flaky test-crypto-classes.js
c7669db 
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 13, 2018
@bengl @MylesBorins
test: fix flaky test-crypto-classes.js
365dba2 
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-crypto-classes.js bengl/node
4 participants
@mscdex @bengl @BridgeAR @mhdawson