Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc events: Erroneous reference to EventListener #16789

Closed
gowpen opened this issue Nov 6, 2017 · 1 comment
Closed

doc events: Erroneous reference to EventListener #16789

gowpen opened this issue Nov 6, 2017 · 1 comment
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.

Comments

@gowpen
Copy link
Contributor

gowpen commented Nov 6, 2017

  • Version: v9.0.0

The docs contain an erroneous reference to EventListener. I believe it's meant to be a reference to EventEmitter.

Location:

Current text:

The EventListener class calls all listeners synchronously ..

Proposed correct text:

The EventEmitter class calls all listeners synchronously ..
gowpen added a commit to gowpen/node that referenced this issue Nov 6, 2017
@gowpen
doc: correct EventEmitter reference
c047fb6 
Fixes: nodejs#16789
@benjamingr
Copy link
Member

Thanks for spotting the issue and for fixing it in your fork. If you go ahead and open a pull request I'll approve it and after a few other collaborators took a look we'll land it. Thanks :)

@gowpen gowpen mentioned this issue Nov 6, 2017
Closed
3 tasks
@mscdex mscdex added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Nov 6, 2017
@jasnell jasnell closed this as completed in b5f0578 Nov 6, 2017
cjihrig pushed a commit to cjihrig/node that referenced this issue Nov 6, 2017
@gowpen @cjihrig
doc: correct EventEmitter reference
d7df4df 
PR-URL: nodejs#16791
Fixes: nodejs#16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 14, 2017
@gowpen @MylesBorins
doc: correct EventEmitter reference
6af9311 
PR-URL: #16791
Fixes: #16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Dec 19, 2017
@gowpen @MylesBorins
doc: correct EventEmitter reference
97689c6 
PR-URL: #16791
Fixes: #16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this issue Dec 20, 2017
@gowpen @gibfahn
doc: correct EventEmitter reference
24178ac 
PR-URL: #16791
Fixes: #16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: correct EventEmitter reference gowpen/node
3 participants
@mscdex @benjamingr @gowpen