Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please use less memory in test-zlib #17986

Closed
kapouer opened this issue Jan 4, 2018 · 3 comments
Closed

please use less memory in test-zlib #17986

kapouer opened this issue Jan 4, 2018 · 3 comments
Labels
test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.

Comments

@kapouer
Copy link
Contributor

kapouer commented Jan 4, 2018

This line

node/test/parallel/test-zlib.js

Line 160 in 11dda69

const node = fs.createReadStream(process.execPath);

consumes a lot of memory during tests.
Some platforms will not have enough memory and will somewhat wrongfully fail the test.
Is it possible to load another file (than process.execPath) ?
Trott added a commit to Trott/io.js that referenced this issue Jan 5, 2018
@Trott
test: use smaller input file for test-zlib.js
1c00fad 
Fixes: nodejs#17986
@Trott Trott mentioned this issue Jan 5, 2018
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Jan 5, 2018

Hi, @kapouer! Can you confirm that #17988 fixes this for your situation?

@maclover7 maclover7 added test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem. labels Jan 5, 2018
@kapouer
Copy link
Contributor Author

kapouer commented Jan 5, 2018

Thanks ! I'm just waiting for the mips build server (where it fails more often) to finish. Will confirm tomorrow UTC+1 :)

@kapouer
Copy link
Contributor Author

kapouer commented Jan 5, 2018

I confirm that the test pass now.

evanlucas pushed a commit that referenced this issue Jan 22, 2018
@Trott @evanlucas
test: use smaller input file for test-zlib.js
8778090 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas pushed a commit that referenced this issue Jan 30, 2018
@Trott @evanlucas
test: use smaller input file for test-zlib.js
3456e61 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 27, 2018
@Trott @MylesBorins
test: use smaller input file for test-zlib.js
66a19cf 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 27, 2018
@Trott @MylesBorins
test: use smaller input file for test-zlib.js
16ef24b 
PR-URL: #17988
Fixes: #17986
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: use smaller input file for test-zlib.js Trott/io.js
3 participants
@kapouer @Trott @maclover7